added gcm #32
Open
added gcm #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But I think the repo is dead?? |
|
Sorry, I haven’t been very attentive at updating this repo or the related package. I should look for a co-maintainer at the very least that actively works with Python. I was actually hoping that by now AES would be an important enough primitive it would be part of the python standard library by now, but it sounds like that isn’t the case? |
|
thats sad but this library has an advantage over the popular library "pycryptodome". This library mainly focus on AES and is therefore small and lightweight. I would really like if you keep this up! |
|
While it's a good start, this PR breaks when passed IVs >96 bits and also does not handle authentication tags at all (which are the whole point of GCM mode). |
|
please help me fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing of course