Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS 5.x #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CentOS 5.x #59

wants to merge 2 commits into from

Conversation

lifanov
Copy link

@lifanov lifanov commented Dec 3, 2018

Simple changes to build on CentOS 5.

@richfelker
Copy link
Owner

I don't see what the motivation for adding Linux 2.6.16 is. There is no reason to want it to match the kernel version used on the host you're compiling on (these things have nothing to do with each other) and an ancient kernel like that is just more likely to have headers that clash with userspace use or have other bugs. We should really avoid adding more kernel versions unless they're known to provide headers with better compatibility than the versions we already have.

For tar, I think it's welcome to support tar versions without the J option, but I think this patch is also likely to break building on systems that don't have the xz command installed. I think a patch that made either setup work would be acceptable though.

@lifanov
Copy link
Author

lifanov commented Dec 17, 2018

Okay, I'll work on a patch that would support both. For xz, it would break the case where tar is from libarchive, since gnu tar needs xz to work even with support.

The motivation is to create a toolchain that targets CentOS 5.

@richfelker
Copy link
Owner

In "The motivation is to create a toolchain that targets CentOS 5", do you mean motivation for using old kernel headers? This is not necessary. New kernel headers work perfectly fine for producing programs to run on an old kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants