Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug and Add Test Cases #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tstinebaugh
Copy link

While poking around this repo, I noticed the utils functions were mainly untested, so I added a few tests to increase coverage. I also found a bug in the add_reflection method where the default bgcolor was missing a 0 to be a true hexidecimal value.

While poking around this repo, I noticed the utils functions were mainly untested, so I added a few tests to increase coverage. I also found a bug in the add_reflection method where the default bgcolor was missing a 0 to be a true hexidecimal value.
@richardbarran
Copy link
Owner

Hi! Thanks for the MR and for spotting the bug with the color code.

I have a couple of suggestions/requests:

  1. I suggest that in your local repo you add your new code to a new branch (not master). It makes it harder for the reviewer (me) to checkout and test your branch on my own PC as I already have a master branch.
  2. The CI unit tests have failed. I strongly suspect that it's because of the sys.path.append statement in the unit tests; this should never be necessary. There must be a broken/incorrect import statement somewhere else in the codebase.

I look forward to hearing from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants