Add prettyPrint config

richardDobron · Jun 21, 2023 · f7c5559 · f7c5559
1 parent a3db7ae
commit f7c5559
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/docs/getting_started.md b/docs/getting_started.md
@@ -40,6 +40,7 @@ The following options can be defined:
 Below are the less important parameters.
 
 * **collectFbt** `bool`: (Default: `true`) Collect fbt instances from the source and store them to a JSON file.
+* **prettyPrint** `bool`: (Default: `true`) Pretty print source strings in a JSON file.
 * **hash_module** `string`: (Default: `md5`) Hash module.
 * **md5_digest** `string`: (Default: `hex`) MD5 digest.
 * **driver** `string`: (Default: `json`) Currently, only JSON storage is supported.
@@ -61,7 +62,7 @@ use fbt\Runtime\Gender;
 
 class UserDTO implements IntlViewerContextInterface
 {
-    public function getLocale(): ?string
+    public function getLocale(): string
     {
         return $this->locale;
     }

diff --git a/src/fbt/FbtConfig.php b/src/fbt/FbtConfig.php
@@ -55,6 +55,11 @@ class FbtConfig
          */
         'path' => null,
 
+        /*
+         * Pretty print source strings in a JSON file.
+         */
+        'prettyPrint' => true,
+
         /*
          * Common string's, e.g. [['text' => 'desc'], ...].
          */

diff --git a/src/fbt/Runtime/Shared/FbtHooks.php b/src/fbt/Runtime/Shared/FbtHooks.php
@@ -185,7 +185,13 @@ public static function storePhrases()
             $parentIds[$index] = self::savePhrase($phrase, $parentIds[$parentKey] ?? null);
         }
 
-        file_put_contents($file, json_encode(self::$sourceStrings), LOCK_EX);
+        $flags = 0;
+
+        if (FbtConfig::get('prettyPrint')) {
+            $flags |= JSON_PRETTY_PRINT;
+        }
+
+        file_put_contents($file, json_encode(self::$sourceStrings, $flags), LOCK_EX);
 
         FbtTransform::$childToParent = [];
         FbtTransform::$phrases = [];