Fixed issue#491 #528
Open
Fixed issue#491 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s3mic0lin I had the same problem as you described, I tried your fix and it worked for me! |
|
I could use this fix in the NuGet version of this library as well. |
|
Also line 41-47 in EventEvaluator reset rdate EndTime values even if they are supplied (and appear to be redundant to 50-56). i.e. if I add periods with different durations to RecurrenceDates of an event, EventEvaluator resets them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #491
Duration and end time was not appended to period. By checking for p.Endtime.HasTime adding end time or duration was ensured.
Unit tests passed.