Fixes for choc option #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed issue with non square key switch holes; - Reduced left (right) sidewall height of keyholes to fixed 2.2 for the clamps to grip; - fixed keyheight offset to be level with the surrounding plate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental choc option had some issues with the keyholes that I have addressed.
open issue; For the 1.5u thumb buttons, the keyhole should be rotated 90 degrees to allow the rotated mount of the button for usage of horizontal keycaps instead of harder to source vertical ones (At least as option).
Tested the changes with the FDM print of this Manuform:
#manuform:Ch4IBhAEGgNzaXgiBHplcm8qBGNob2MyBW91dGllOAAaCggAEgRub25lGAAiF1UAAABBGAAgAV0AAOBAZQAAQEBAAEgAMvkBlQMAACBAnQMAAAAAgAMBiAMBDc3MTL4VAAAAAB1mZsZAJQAAsMAtzcxEwTUAAGBAPWZm5j9FmpmZPk2amblAVQAAQMBdAACgQGUzM3nCbTMzEcJ1AADQwXjCA4ABvxaIAdgTlQEzMy/CnQEzM03CpQEAAMjBqAGqBrABixW4AYgOxQEAAETCzQEAAMzB1QEAAHDB2AHQBeABixXoAbgI9QEAAOjB/QEAACTChQIAAGDBiALGCpAClRCYAvYEpQIAAAzCrQIAAHDBtQIAAKDAuAKEB8ACyRHIAoQH1QIAAHjB3QIAAGDB5QIAACBA6AKEB/AClRD4AsIDKgYIABAAGAA=
Beside the too low Vertical (Y) Spacing setting used, the Kailh Choc switches fit perfectly.