tpm: Don't return an error if event log is full #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't return an error if the firmware's event log is full. The PCR should still be extended in this case so there is no reason to make the system unbootable.
|
Yeah, I'd like to see it logged once. Otherwise this looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't return an error if the firmware's event log is full. The PCR should still be extended in this case so there is no reason to make the system unbootable.
As discussed previously, it seems like we shouldn't fail to boot if the firmware's (limited size) TPM event log fills up. The events should still cause the target PCRs to be extended in this case.
Maybe we should warn on console and pass this information to the OS too?