Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel build of gnu-efi #643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix parallel build of gnu-efi #643

wants to merge 1 commit into from

Commits on Feb 29, 2024

  1. Fix parallel build of gnu-efi 

    When building with make 4.4.1, gnu-efi may be built twice and in parallel:

  $ make -n -j ARCH=x86_64 2>&1 | tee build.log
  $ grep -e 'make -C gnu-efi' build.log
  make -C gnu-efi \
  make -C gnu-efi \

This has been seen to cause linking failures when building libgnuefi.a because
some object files may end up truncated.

The reason for this is that make interprets multiple targets in the same rule
as independent and can run the rule multiple times. The solution is to define a
grouped target with &:, which causes make to behave the way one expects: runs
the rule once and expects it to create all targets.

Grouped target support was added in make 4.3 released 4 years ago.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
    @jepio
    jepio committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f100876 View commit details
    Browse the repository at this point in the history