Use #pragma once in header files #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All compilers have supported this for at least the 5 years, some like gcc and clang much longer. Signed-off-by: Richard Hughes <richard@hughsie.com>
hughsie
force-pushed
the
rhughes/pragma-once
branch
from
d2b310b
to
10566e0
Compare
|
I'm a bit concerned with replacing a well known and understood pattern with a pragma that has been "supported" for years but is completely undocumented. What do we gain? |
Not much -- but it modernizes the codebase and means we can add extra .h files for things like the test suite without verifying the define is duplicate. Having a non-local define like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All compilers have supported this for at least the 5 years, some like gcc and clang much longer.