Set bookmarks' default shortcut to an unused value, #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJKL
force-pushed
the
drjkl/bookmark-increment
branch
from
72ad6a6
to
d9060e6
Compare
bookmark_increment.mp4 |
|
Note: Doesn't handle cloning yet. Might be worth adding onCloned to the base node to allow for that. |
rgthree
reviewed
Apr 20, 2024
src_web/comfyui/bookmark.ts
Outdated
| return usedShortcuts; | ||
| } | ||
|
|
||
| const SHORTCUT_DEFAULTS = `1234567890abcdefghijklmnopqrstuvwxyz`; |
There was a problem hiding this comment.
Use regular quotes and split this upfront in the const:
const SHORTCUT_DEFAULTS = "1234567890abcdefghijklmnopqrstuvwxyz".split("");
src_web/comfyui/bookmark.ts
Outdated
|
|
||
| function getNextShortcut() { | ||
| const existingShortcuts = getExistingShortcuts(); | ||
| for (const char of SHORTCUT_DEFAULTS.split('')) { |
There was a problem hiding this comment.
I think this can use find:
return SHORTCUT_DEFAULTS.find((char) => !existingShortcuts.has(char)) ?? '1';
|
Nice! |
DrJKL
force-pushed
the
drjkl/bookmark-increment
branch
from
3cc7d9a
to
fdca8d7
Compare
rgthree
approved these changes
Apr 21, 2024
DrJKL
force-pushed
the
drjkl/bookmark-increment
branch
from
61e6640
to
bcbd1c7
Compare
|
Rebased to include the other change. |
DrJKL
force-pushed
the
drjkl/bookmark-increment
branch
from
bcbd1c7
to
f25a161
Compare
DrJKL
force-pushed
the
drjkl/bookmark-increment
branch
from
f25a161
to
738441a
Compare
|
Updated with the recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for the first 36...
Duplicates the
shortcutKeygetter in #198