Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against a specific geos version #355

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mylesboone
Copy link
Contributor

Summary

This implements #350

Other Information

More versions can be added. I'm not sure which versions are technically supported

Windows here isn't accomplishing anything and adding it as a feature
should be tracked in github
@mylesboone mylesboone force-pushed the ci_test_multiple_geos_versions branch from 9b68066 to 560fbe1 Compare April 2, 2023 19:06
@mylesboone
Copy link
Contributor Author

@keithdoggett Looks like macos and geos version 3.10+ work as expected.
geos version <3.10 fail tests everywhere. geos with ubuntu fails (and capi and ffi support not available)
Any ideas?

@keithdoggett
Copy link
Member

@mylesboone thank you for the work on this!

  • Geos < 3.10 failing. In version 3.10 they redid some of the validity checks, so the tests that are failing expect one kind of error, but we're getting another. "Duplicate-Ring" vs. "Self-Intersection". I'm not sure the best way to handle this. We could check for either message or make a conditional based on the geos version. @BuonOmo what are your thoughts?
  • Not sure about all the ubuntu builds failing. Quickly looked through the build logs and didn't notice anything failing during setup. I'll take a longer look through soon and see if I can figure it out.

@BuonOmo
Copy link
Member

BuonOmo commented Apr 3, 2023

@keithdoggett I'd say we follow Geos version, and adapt the test to the version with a conditional. I feel like having these kind of conditions directly in the codebase may lead to some weird behaviors later..

@keithdoggett
Copy link
Member

@BuonOmo I agree that's best too. @mylesboone So I guess what we can do is once we get ubuntu figured out, I'll open a new branch and this will be failing but we can merge into that and in that new branch we can add conditionals to the tests based on geos version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants