New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against a specific geos version #355
base: main
Are you sure you want to change the base?
Conversation
Windows here isn't accomplishing anything and adding it as a feature should be tracked in github
9b68066
to
560fbe1
Compare
@keithdoggett Looks like macos and geos version 3.10+ work as expected. |
@mylesboone thank you for the work on this!
|
@keithdoggett I'd say we follow Geos version, and adapt the test to the version with a conditional. I feel like having these kind of conditions directly in the codebase may lead to some weird behaviors later.. |
@BuonOmo I agree that's best too. @mylesboone So I guess what we can do is once we get ubuntu figured out, I'll open a new branch and this will be failing but we can merge into that and in that new branch we can add conditionals to the tests based on geos version. |
Summary
This implements #350
Other Information
More versions can be added. I'm not sure which versions are technically supported