fix: handle null emits #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now, this is the field behavior: |
duydvu
reviewed
Oct 27, 2022
| const expression = match.slice(2, -2).trim(); | ||
| return parseExpression(expression, values.value); | ||
| }); | ||
|
|
||
| if (!computedValue) { |
There was a problem hiding this comment.
If computedValue is a valid falsy value (0, false), it would still return null. That is not intended in some cases such as subtract or boolean expression.
duydvu
reviewed
Oct 27, 2022
| const valueA = parseExpression(a, values); | ||
| if (!valueA) { |
There was a problem hiding this comment.
Same as above if valueA is a valid falsy value.
|
Because all types are valid, even null (NULL & NOT_NULL operators), we cannot pre-check whether a value is valid or not. I think it is best to leave the responsibility of checking unintended values to the operators. I still can't reproduce your issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies when the parsed expression returns a empty value and properly emits
null, so Directus can take care of the empty field.Closes #7