Add onError and onSuccess callbacks #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmssd
approved these changes
Aug 13, 2019
|
@revolunet Hi Julien, could we merge this? Alternatively the subscribe function could return a promise. |
markmssd
reviewed
Jun 13, 2022
Comment on lines
+64
to
+65
| onSuccess: PropTypes.func, | ||
| onError: PropTypes.func, |
There was a problem hiding this comment.
Those are missing defaultProps below. For functions, it's a good practice to give a default value of a noop () => {} function.
Then, you won't need the if(this.props.onSuccess!==undefined) checks anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.