Fix enter key sending message while still composing, when using Safari on Mac. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1atdev
changed the title
insertish
requested changes
Sep 24, 2021
Comment on lines
+192
to
+197
| textBox?.addEventListener("compositionstart", () => { | ||
| setComposed(false); | ||
| }); | ||
| textBox?.addEventListener("compositionend", () => { | ||
| setComposed(true); | ||
| }); |
There was a problem hiding this comment.
Can this not just use React event bindings?
There was a problem hiding this comment.
I tried React's onCompositionStart and onCompositionEnd, but they didn't work in my environment. (There is still a bug in this event, which may be the reason.)
facebook/react#3926
So I am using addEventListener. If I could replace them with onCompositionStart/End, I think that would be better.
|
Closing due to rewrite, marking as potential issue in future by linking to revoltchat/frontend#64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #257 fix not working while using Safari on Mac.
Even though #257 is applied, Safari on Mac has the same bug as #261, as shown in the video below.
2021-09-21.21.13.57.mov
#257 fix alone will not work in Safari on Mac because of the special nature of Safari's
isComposingsystem.