Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file open helper which fixes opening files with too strict FileShare configuration #496

Merged
merged 5 commits into from Mar 20, 2024

Conversation

devedse
Copy link
Contributor

@devedse devedse commented Mar 17, 2024

This PR will solve issues where FileFlows is opening files for a specific purpose but blocking other applications to continue writing.

For example:

File.OpenRead()
Calls:
        public static FileStream OpenRead(string path)
            => new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read);

This sets FileShare to .Read this locks the file for all other applications trying to write to it. Thus causing permission issues when for example doing a copy.

CLA

[X] I agree that by opening a pull requests I am handing over copyright ownership of my work contained in that pull request to the FileFlows project and the project owner. My contribution will become licensed under the same license as the overall project.

@revenz revenz merged commit c090929 into revenz:develop Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants