Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced by yaml properties update #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaecramb
Copy link

Fix #194

@edamamev
Copy link

edamamev commented Sep 1, 2023

AH! So we just have to build the files with npm according to this website.
Disregard, but thanks for the addition!

---First Note---
Hey @chaecramb !
I was wondering whether you could fork your change so we could have access to the working plugin?
I'm not sure how to convert your solution into something that Obsidian will run. Any advice or help would be cool :)
Thanks!

Copy link

@edamamev edamamev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm: this fix works oml

@dangtrivan15
Copy link

I crave for this PR :(

@becknik
Copy link

becknik commented Sep 7, 2023

This basically renders the plugin unusable for the 1.4 release on the 31. august.

Please merge this already, people like me rely on this plugin for their exam preparation!

@QuinnHerden
Copy link

+1

Please, merge this @reuseman :)

@edamamev
Copy link

Ok, for people who want a plugin that works, feel free to go to https://github.com/edamame-v/flashcards-obsidian for a forked copy of this plugin.

The only change is this Fix, feel free to give it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major bug: Incompatible with Obsidian's latest core plugin "properties"
5 participants