-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RethinkDB 2.4.2 release list #6975
Comments
I think it is better to leave coffeescript as is, write new official admin client and then remove admin frontend completely |
And what about making more releases, even with less changes? |
@srh we could add to the list a new version of the python client that includes some refractors type hints, dropped python 2 support, and some more that we worked on with @lsabi in the past couple of months. Regarding the JS client, we could replace it with the TS one, but that's a separate discussion. |
In order to keep track of the completed tasks, we could use github's projects (or whatever it is called). Otherwise, editing the first comment and updating what's done and what's not. |
Is the TS client drop-in compatible with the JS client? I mean, is it supposed to be? |
@srh No, it's API differs drastically. The only common thing are queries. Connection creation, query running, etc differs. |
That is a good idea , this will bring users back to RethinkDB.
I thought there was an attempt to develop seperate admin frontend. |
If the TypeScript client isn't compatible then we shouldn't replace the JS client with it. |
There's a [fork of QuickJS with Windows support](https://github com/c-smile/quickjspp) (and other functionality that can be disabled) that's used in Sciter, maybe that could be useful? |
When will it be released? |
My Mac M1 is just waiting to be released for use. |
Auto-rebalance. I.e. when a server is gone and replaced with a new one, DB/tables should be automatically rebalanced (re-sharded/re-replicated) to a new server. In our case, we use AWS EC2 Autoscaling to run servers and have to use custom scripts to rebalance DB/tables after instance replacement by Autoscaling. |
is this a bot? |
I have allocated some time to get this completed and out. |
Moving Windows support to Nice-to-have. I think it's doable, but it's below the line right now. |
If you have a platform (aside from Ubuntu or Debian) you want packages to be built for, it wouldn't hurt to comment here. |
Linux ARM builds are basically working on Ubuntu 20.04 and Bullseye. I haven't tested others. I'm considering moving them to "Mandatory", simply because they seem to be working out of the box. |
Decisions on updating package dependencies: boost - Don't want to mess with datetime behavior, keep version unchanged. So, openssl, libidn, jemalloc, and curl have been updated, but only jemalloc will affect release packages. Currently in branch https://github.com/srh/rethinkdb/tree/srh/dependencies . Building works on Ubuntu 20.04, but I need to check that building works on other platforms. I think we should change package build scripts, or all build scripts, to statically link re2 and boost, because differing versions could affect query language behavior. |
It looks like AlmaLinux and CentOS 7 will be able to have packages. I presume RockyLinux will too, I haven't gotten to that yet. |
RockyLinux 8 works, CentOS 7 works, and Xenial and Trusty now work thanks to the changes made for CentOS 7. |
Moved "Mac ARM build" to mandatory. ARM macbooks are the only good macbooks now. It now compiles and runs (and generally works). DMG building is the only thing that needs updating. It depends on whether I get it done before Jammy comes out. |
Moved "Mac ARM build" back out. It requires updates to stuff in packaging/osx, and the result is we're getting an empty dmg. Maybe somebody who wants a Mac M1 dmg could make a PR. Right now RethinkDB builds on Mac M1. |
Currently thinking about tagging the tip of v2.4.x v2.4.2. |
It's tagged; if there's a problem we'll have to do v2.4.3. Kicking off builds now. |
https://rethinkdb.com/blog/2.4.2-release Done. Some more improvements, like a Mac M1 ARM .dmg release, or a Windows release, will require bumping the version (which is no big deal). |
When new docker image gonna be supplied? |
Maybe tomorrow? Keep pinging me so I don't forget about it. I'd do it right now, but it's 9:32 PM here, and thus I'm likely to mess something up than earlier in the day. I've never dealt with the rethinkdb-dockerfiles repo before. |
Or maybe somebody could make a PR :-) |
Not hurrying at all lol, that's fine, take your time:) |
@atassis the dockerfiles were updated yesterday (rethinkdb/rethinkdb-dockerfiles#59) though docker hub not yet. I'm going to open a PR on their end soon. Though you can do too, if you would not like to wait. If I'm right it is about ~2 lines of change |
The purpose of this ticket is to start a list of features needed for the next release. I'm not sure whether the next release should be numbered 2.4.2 or 2.5.0 (because of the v8 -> quickjs list).
Mandatory(?):
Look at Add the packaging metadata to build the rethinkdb snap #6247Mac M1 heap corruption observed in unit tests #7041DiskConflictTest.WriteWriteConflict unit test failing with crash or assertion failure #7042Get working with latest Clang versions: Assertion fails on restart when compiled with later Clang versions #7036Address HTTP 2 issues with r.http throws ReqlNonExistenceError #6968Replace v8 with QuickJS: Drop r.js support? Use Duktape? #6960The RethinkDB Hirsute (Ubuntu 21.04) build needs to work (by replacing v8 with QuickJS): Ubuntu 21.04 Hirsute package #6959 - builds, packages workUbuntu 21.10 (Impish) supportUbuntu 22.04 (Jammy) supportUbuntu 20.04 (Focal) supportUbuntu 18.04 (Bionic) supportUbuntu 16.04 (Xenial) supportDebian 11 (Bullseye) support - Cannot install/build 2.4.1 on Debian 11 (Bullseye) #6989Debian 10 (Buster) supportDebian 9 (Stretch) supportCentOS 7 supportRockyLinux, AlmaLinux supportAlpine/Musl supportCXX=clang++
if still necessaryFix warnings when building with g++ - Silence more GCC warnings #7020, Fix more GCC warnings #7018, Fix saslname_decode logic in =2C and =3D escaping, and some GCC warnings #7016Split off Admin UI and drivers: Split off Admin UI and driver code for 2.4.2 #6979Find a place for the old admin uiweb_assets.cc generation needs to work on Debian Bullseyeand Ubuntu JammyVerify ARM builds are basically working.Verify source packages contain the vendored/ subrepo checkout.Fix RethinkDB crashes on machine with 128 CPUs #6895Ensure we don't build with incorrect state of vendored repo directory when it is already checked outAddress existing recent PR's:try to fix memory leak #6957Upgrade nodejs6 (v2.4) #6970 - but under Split off Admin UI and driver code for 2.4.2 #6979 it may be appropriate for the admin repositoryUpdate README.md #7017 - figure out proper python setup instructions w.r.t. Python 2 and Python 3Add AARCH64 Flag in Architecture Clause #6949 - aarch64 flags in context_switching.cc - see also build fails on AArch64, Fedora 33 #6952Update build system dependencies to later versions (even if not necessary)and revisit RethinkDB v2.4.1 centos requires protobuf on aarch64 #6993Update rethinkdb-package-builder to a new v2.4.2 support commit and dockerfile codemake it explicitly fetch dependenciesscripts/build-rpm.sh must not use --fetch all -- have it dynamically link libcurl, openssl, libidn, and (because why not) zlibRegenerate web_assets.cc with the 2.4.2 version number.Nice-to-haves:
Doubtful nice-to-haves:
Update rethinkdb-package-builder to use g++ instead of clang for 2.4.2 and later (but why bother?)Very Doubtful
Extended LTS or Extended Security Maintenance Debian/UbuntuUbuntu 14.04 (Trusty) support - QuickJS build does not work - ESM ends April 2024Debian 8 (Jessie) support - QuickJS build does not work - ELTS ends June 2022Drivers?:
The text was updated successfully, but these errors were encountered: