Replace returnVals by returnChanges #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2015
| @@ -84,7 +84,7 @@ function* update(next) { | |||
| throw new Error("The todo must have a field `id`."); | |||
| } | |||
|
|
|||
| var result = yield r.table('todos').get(todo.id).update(todo, {returnVals: true}).run(this._rdbConn); | |||
| var result = yield r.table('todos').get(todo.id).update(todo, {returnChanges: true}).run(this._rdbConn); | |||
| this.body = JSON.stringify(result.new_val); | |||
There was a problem hiding this comment.
This line needs updating I believe.
There was a problem hiding this comment.
Sorry. I believe it should be result.changes[0].new_val -- but i'm not sure of the impact of only looking at [0]
and sometimes, there is no new_val property if there was no change (ie: they made the call but it was with identical data as what already was in the db.
I also noticed I didn't need to JSON.stringify. I think koa will do that for us.
There was a problem hiding this comment.
You are right! Didn't think about it enough. I opened #14 so we don't forget changing that.
deontologician
added a commit
that referenced
this pull request
May 20, 2015
Replace returnVals by returnChanges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #11 and #12 .
@deontologician could you review please?