Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ REQUEST: Updating the resume cards for adding more options #156

Open
1 task done
Tracked by #149
viveknigam3003 opened this issue Oct 12, 2022 · 6 comments
Open
1 task done
Tracked by #149
Labels
enhancement New feature or request Hacktoberfest PRs/Issues for Hacktoberfest Level 2 Intermediate level patches updates. Tech-stack knowledge needed.

Comments

@viveknigam3003
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

The resume cards are shown on the home screen but have no visual cue for opening the edit modal where we change the name and icon for it. Upon clicking it opens the Resume metadata edit dialogue box. We need to update this whole experience to

  • Add a visual cue to have edit, delete, and icon change etc visible.
  • Add a download button right outside on the Home page to help users download the resume without going to the Download page.
image Screen Shot 2022-10-12 at 1 44 49 PM

Describe the solution you'd like

We may have an experience where instead of hovering on the name, when we hover on the card we get multiple options [Image 1] OR another option could be like what Airtable does having an arrow button to open the options modal [Image 2]. There can be other options we can discuss.

For Image 1 [on the left]

  • The edit button takes you to edit the resume (i.e. on the create page)
  • The settings button opens up the modal to edit name, icon, and delete
  • The download button directly downloads the resume.
Hover_On_Card Screen Shot 2022-10-12 at 4 29 22 PM

Describe alternatives you've considered

No response

Additional context

No response

@viveknigam3003 viveknigam3003 added enhancement New feature or request Hacktoberfest PRs/Issues for Hacktoberfest Level 2 Intermediate level patches updates. Tech-stack knowledge needed. labels Oct 12, 2022
@Saurav-Singh-Rauthan
Copy link

Saurav-Singh-Rauthan commented Oct 28, 2022

hi @viveknigam3003 i would like to give it a try
can you also specify the path to folder where the tsx files for cards and relative methods( downloading, edit modal(open/close) ) are
Thank you!

@viveknigam3003
Copy link
Member Author

Sure @Saurav-Singh-Rauthan! Please share your approach here for discussion.

@Saurav-Singh-Rauthan
Copy link

I'm thinking of creating a div in the card component in which all these icons will be present (edit download etc) and using react's usestate i can show/hide it based on mouseover event

@viveknigam3003
Copy link
Member Author

Hey @Saurav-Singh-Rauthan, in #181 @syedzubeen has presented another solution that we can have a context menu for every card, which sounds more interesting to me and would be less ambiguous in design as well. Let's see if we can explore more on that front.

What are your thoughts @merrcury?

@Saurav-Singh-Rauthan
Copy link

Hey @Saurav-Singh-Rauthan, in #181 @syedzubeen has presented another solution that we can have a context menu for every card, which sounds more interesting to me and would be less ambiguous in design as well. Let's see if we can explore more on that front.

What are your thoughts @merrcury?

are you talking about the approach in image 2?

@viveknigam3003
Copy link
Member Author

Hey @Saurav-Singh-Rauthan, in #181 @syedzubeen has presented another solution that we can have a context menu for every card, which sounds more interesting to me and would be less ambiguous in design as well. Let's see if we can explore more on that front.
What are your thoughts @merrcury?

are you talking about the approach in image 2?

No no, the design is not included here yet. I'm saying we can add a right-click menu (context menu) for the resume. Since we use Chakra UI v1 as our design system you can have a look at this for the menu component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest PRs/Issues for Hacktoberfest Level 2 Intermediate level patches updates. Tech-stack knowledge needed.
Projects
None yet
Development

No branches or pull requests

2 participants