Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ REQUEST: Resume to be viewable while adding information #110

Open
1 task done
Tracked by #149
lyqht opened this issue Oct 7, 2021 · 18 comments
Open
1 task done
Tracked by #149

➕ REQUEST: Resume to be viewable while adding information #110

lyqht opened this issue Oct 7, 2021 · 18 comments
Labels
Design Issues/PRs to fix design issues. enhancement New feature or request Hacktoberfest PRs/Issues for Hacktoberfest Level 4 Advanced: Adding new feature/functionality to existing code

Comments

@lyqht
Copy link

lyqht commented Oct 7, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

As I scroll down the list and add more information to my resume, I would like to see my resume being updated without having scroll all the way up to the top to see it.

Describe the solution you'd like

Resume to be sticky right

Describe alternatives you've considered

No response

Additional context

No response

@lyqht lyqht added the enhancement New feature or request label Oct 7, 2021
@welcome
Copy link

welcome bot commented Oct 7, 2021

Thanks for digging in and opening an Issue here. Resuminator is awesome because of people like you.

Investigate

Make sure to follow Issue Template & Contributing Guidelines!

@lyqht lyqht changed the title ➕ REQUEST: Resume to stay on the right side while adding information ➕ REQUEST: Resume to be viewable while adding information Oct 7, 2021
@viveknigam3003 viveknigam3003 added Hacktoberfest PRs/Issues for Hacktoberfest Level 4 Advanced: Adding new feature/functionality to existing code labels Oct 7, 2021
@viveknigam3003
Copy link
Member

Hey @lyqht Thanks a lot for using Resuminator and requesting this feature. I do believe it will be great to have such functionality where we can see the resume being updated side-by-side. Let me know if you have any design suggestions in mind through which we can achieve this behaviour?

Also I have added the Hacktoberfest label for this issue, so if we settle on an approach would you mind opening a PR to solve the same?

@viveknigam3003 viveknigam3003 added the Design Issues/PRs to fix design issues. label Oct 7, 2021
@RajdeepDs
Copy link

@viveknigam3003
I would love to contribute to this issue.

@viveknigam3003
Copy link
Member

Awesome to hear that @RajdeepDs 🙌🏼 please share an initial plan on your thought process for solving this one; any ideas you might have? We can have an initial discussion here and then proceed with an agreed solution

@RajdeepDs
Copy link

@viveknigam3003
Firstly, I think we can make navigation bar to sticky top. And the preview part to bit smaller so that it can fit into screen.
We can make left part to be scrollable and the preview part to be sticky right.

I am happy to take inputs from you, so that we can fix this issue.

Thank You,

@viveknigam3003
Copy link
Member

This sounds good @RajdeepDs, one concern I have is that when we make the resume fit to screen then the contents might become too small to be visible.

One thing I'm thinking of after reading your comment is that we can have a mode that can switch between fit-to-screen and fill-on-screen switch. In could be like a floating button or something which can switch between the current view and the one where the resume fits the screen and the right side becomes non-scrollable.

What are your thoughts @merrcury ?

@RajdeepDs
Copy link

@viveknigam3003
Thank you for your response.
I appreciate your thought. Right now, I am thinking that we can give a preview button to preview the resume in full screen, so that it could be a clean and simple UI for the users.
What's your view on this, or we can stick to your thought.

Thank You

@viveknigam3003
Copy link
Member

I think having a full-screen preview is good, but I'm not sure if it wouldn't solve the problem at hand which is that the resume should be viewable while the user is entering their info. I'm open to ideas that solve this problem.

@merrcury
Copy link
Member

merrcury commented Oct 9, 2022

Hey Guys, I would like to add couple more queries to the discussion. What's your thought on two independent scrollable areas? Having a full-screen option is a good idea if we can show that after stripping instead of just a warning line in the side-by-side preview.
What will happen to overflowing content for the fit-to-screen option?

@viveknigam3003
Copy link
Member

Two independent scrolling areas are definitely a great option. I believe it will also allow us to support multiple resume pages (if we reach that point, in the future).

This and we can have a full-screen view to see how to resume looks in one frame. Like a print preview or something?
And since it will be like a print preview, we will automatically be clipping off the overflowing content. What say?

@merrcury
Copy link
Member

Yes, that's exactly what this feature should do, scrolling sections and full screen to show print preview

@merrcury
Copy link
Member

Hi @RajdeepDs, Are you working on this issue?

@louremipsum
Copy link

I was trying out to fix this issue
I had an idea regarding the same
I would suggest that the left bar (Resume Inputs div) is as it is and the Resume Preview is wholly scrollable so that the user can scroll the resume while inputting the data.

kind of like this:
https://www.figma.com/proto/bTdqKgsadtZWAPT3O4G9HH/Untitled?node-id=1%3A4&scaling=min-zoom&page-id=0%3A1
ofc with sticking of preview while scrolling up the main parent element

@merrcury
Copy link
Member

@louremipsum I have couple of doubts

  • Will the preview remain stuck to the screen if we just move the left panel for filling in details?
  • Will the preview be allowed to go out of sight if you keep scrolling downwards or upwards?

@louremipsum
Copy link

There can be a resolution which I thought of which is, although the preview area is scrollable, it will follow to that position wherever there is "focus" on any section on the left side and go back up when pressed out of focus.

and to answer @merrcury questions, Yes for both questions as that was the initial idea I had for this issue.
although my suggestion in this comment above feels more intuitive to me.

@merrcury
Copy link
Member

merrcury commented Oct 27, 2022

it will follow to that position wherever there is "focus"

I like this focus idea

Yes for both questions

I am still not comfortable to get resume out of sight because that is the current problem. I would like that area to restrict.

@louremipsum
Copy link

I'm also not comfortable with the resume going out of sight or "getting lost" in scrollable space
that's why I thought of that focus idea

So I think we can go ahead with that approach unless someone comes up with a better approach.

@mithunsridharan
Copy link

Adding my 2 cents here. I think it's important to separate authoring from preview here. IMO, these should be 2 separate pages. A simple preview button that triggers a modal window with the rendered resume should suffice. When creating their resumes, users will probably focus on the content, grammar, typos, etc. and subsequently view the final output. Putting the two screens side-by-side as in the current version (2.1.6) works on large screens, but not so well on smaller laptop screens. A separate viewing pane that's triggered when a user clicks a preview button is justified here, IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issues/PRs to fix design issues. enhancement New feature or request Hacktoberfest PRs/Issues for Hacktoberfest Level 4 Advanced: Adding new feature/functionality to existing code
Projects
None yet
Development

No branches or pull requests

6 participants