Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport "fix: use more reliable close event" #1963

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

backport "fix: use more reliable close event" #1963

wants to merge 1 commit into from

Conversation

avimar
Copy link
Contributor

@avimar avimar commented Oct 18, 2023 •
edited

Backport e183e5d to enable v6 branch of restify to work with nodejs v16 and up.

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Summarize the issues that discussed these changes

Changes

What does this PR do?

@avimar
backport "fix: use more reliable close event"
25ec27e 
Backport e183e5d to enable v6 branch of restify to work with nodejs v16 and up.
@avimar
Copy link
Contributor Author

avimar commented Jan 8, 2024

This fix is not working for me in node 18. Any other changes that I need to make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@avimar