New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(earliest): Handlers that execute ASAP in the req/res lifecycle #1756
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8a3d170
feat(earliest): Handlers that execute before restify
2e760dd
twitch
6f0ecc1
Revert "twitch"
retrohacker 3b8d174
Revert "feat(earliest): Handlers that execute before restify"
retrohacker 768b3ff
Migrate implementation to match express .handle
retrohacker 1499b4e
Revert "Migrate implementation to match express .handle"
retrohacker 36d63fd
Revert "Revert "feat(earliest): Handlers that execute before restify""
retrohacker 0ad2830
Revert "Revert "twitch""
retrohacker 46f396d
use chain
retrohacker 88e1d23
syncronous inflightRequest calc
retrohacker 4129031
Revert "syncronous inflightRequest calc"
retrohacker d9fb26d
Revert "use chain"
retrohacker 6bfadcc
synchronous inflight accounting
retrohacker b066c4c
forward compat by limiting range of accepted return types
retrohacker c5c9ddb
first instead of earliest and better docs
retrohacker 7037013
moar tests
retrohacker 29b3aad
implement feedback
retrohacker File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we dropped Node6, any reason not to use rest parameters here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting fails.
I originally used
const
andlet
everywhere butmake prepush
failed, so I changed everything back to good ol' ES5.