Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid triggers of the uncaughtException handler #1710

Merged
merged 3 commits into from Oct 30, 2018
Merged

Fix invalid triggers of the uncaughtException handler #1710

merged 3 commits into from Oct 30, 2018

Commits on Oct 26, 2018

  1. Fix invalid triggers of the uncaughtException handler 

    The previous (prior to 7.x) functionality for uncaught exceptions only triggered the `uncaughtException` handler if it was truly an uncaught thrown error. Right now in Restify 7, if you turn on `handleUncaughtExceptions` and add a listener for the event, all errors from `next(err)` and internal errors like `MethodNotAllowed` will trigger the `uncaughtException` handler.
    @mridgway
    mridgway committed Oct 26, 2018
    Copy the full SHA
    99b9238 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Remove duplicate check for handleUncaughtExceptions

    @mridgway
    mridgway committed Oct 29, 2018
    Copy the full SHA
    83c6853 View commit details
    Browse the repository at this point in the history

  2. Add clarification to internal errors test

    @mridgway
    mridgway committed Oct 29, 2018
    Copy the full SHA
    4bfceb0 View commit details
    Browse the repository at this point in the history