Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): address Node v10.x req close event firing order #1672

Merged
merged 15 commits into from Jun 7, 2018
Merged

fix(server): address Node v10.x req close event firing order #1672

merged 15 commits into from Jun 7, 2018

Commits on Jun 6, 2018

  1. fix(restify): handle res close event in Node >= 10 

    Changes introduced in:
nodejs/node#20941
nodejs/node#20611
    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    929f9a1 View commit details
    Browse the repository at this point in the history

  2. docs(server): fix close event comments

    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    b237d3e View commit details
    Browse the repository at this point in the history

  3. fix(server): fix req/res lifecycle state machine

    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    99bc0bf View commit details
    Browse the repository at this point in the history

  4. test(metrics): fix tests for Node < 10

    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    c54c3c1 View commit details
    Browse the repository at this point in the history

  5. fix(server): set connectionState to close only when req is early closed

    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    5996573 View commit details
    Browse the repository at this point in the history

  6. docs(server): RequestCloseError improve logs

    Peter Marton committed Jun 6, 2018
    Copy the full SHA
    245a91d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. refactor(server): use aborted event instead of close to determinate R… 

    …equestCloseError
    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    f82c3a6 View commit details
    Browse the repository at this point in the history

  2. feat(server): improve close

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    b84caa8 View commit details
    Browse the repository at this point in the history

  3. docs(server): fix typos

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    4e8e5de View commit details
    Browse the repository at this point in the history

  4. test(metrics): use process specific assertations

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    6cb9fc7 View commit details
    Browse the repository at this point in the history

  5. fix(server): do not set connction state to close in happy path

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    ee3b338 View commit details
    Browse the repository at this point in the history

  6. docs(server): improve res close event docs

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    df356c9 View commit details
    Browse the repository at this point in the history

  7. test(metrics): add a test without timeouts

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    10410fb View commit details
    Browse the repository at this point in the history

  8. test(server): add a test without timeouts

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    def6164 View commit details
    Browse the repository at this point in the history

  9. refactor(server): remove res._sent from req close handling

    Peter Marton committed Jun 7, 2018
    Copy the full SHA
    3d0bd42 View commit details
    Browse the repository at this point in the history