Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workaround to fix changed route based on regular expression while… #1582

Closed
wants to merge 1 commit into from

Conversation

s-a
Copy link

@s-a s-a commented Dec 9, 2017

Currently the initialization process seems to change routes based on RegEx. I do not expect that you will accept this PR. It is intended to point out the problematic code. I think this code change is only a workaround for #1581 because from my point of view we should not change the initial regular expression passed to .getmethod where

/\bv?(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)(?:-[\da-z-]+(?:\.[\da-z-]+)*)?(?:\+[\da-z-]+(?:\.[\da-z-]+)*)?\/?.*\b/ changes to
/\bv?(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)(?:-[\da-z-]+(?:\.[\da-z-]+)*)?(?:\+[\da-z-]+(?:\.[\da-z-]+)*)?\/?.*\b/gi. I am not a RegExpert but I think this should not make a difference and it changes back to original RegEx at runtime but it leads to fail matchURL

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

@stale
Copy link

stale bot commented Apr 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Apr 10, 2018
@stale
Copy link

stale bot commented Apr 24, 2018

This issue has been automatically closed as stale because it has not had recent activity.

@stale stale bot closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant