Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): avoid http2 experimental warning without http2 option #1555

Merged
merged 1 commit into from Nov 3, 2017
Merged

fix(server): avoid http2 experimental warning without http2 option #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 11 additions & 8 deletions lib/server.js
View file
Open in desktop
Expand Up @@ -30,14 +30,6 @@ var patchResponse = require('./response');

var http2;

// http2 module is not available < v8.4.0 (only with flag <= 8.8.0)
try {
http2 = require('http2');
patchResponse(http2.Http2ServerResponse);
patchRequest(http2.Http2ServerRequest);
// eslint-disable-next-line no-empty
} catch (err) {}

patchResponse(http.ServerResponse);
patchRequest(http.IncomingMessage);

Expand Down Expand Up @@ -137,6 +129,17 @@ function Server(options) {
this.spdy = true;
this.server = spdy.createServer(options.spdy);
} else if (options.http2) {
// http2 module is not available < v8.4.0 (only with flag <= 8.8.0)
// load http2 module here to avoid experimental warning in other cases
if (!http2) {
try {
http2 = require('http2');
patchResponse(http2.Http2ServerResponse);
patchRequest(http2.Http2ServerRequest);
// eslint-disable-next-line no-empty
} catch (err) {}
}

assert(
http2,
'http2 module is not available, ' +
Expand Down