Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepush
Included comprehensive and convincing tests for changesChanges
With the release of 6.2.0 (09066d8) the unleash package got added as a dependency of this project. I suppose this happened accidentally, as it's not a real runtime dependency of this project.
Aside from downloading unnecessary bytes this has a very unfortunate consequence.
With the unleash package both "npm-check" and "npm" end up in the users
node_modules/.bin
folder.Now if you run
npx
inside a project that uses restify, ornpx npm-check -u
for that matter, you end up withunleash
's outdated npm-check version, and even worse with an npm@2.This lead to verify confusing and seemingly unrelated error messages – until I could track it down to this slip-up in restify.
I hope my changes are in the right format, so you can merge this PR directly and release a new version.
I also removed
lodash
from devDependencies, because it's a dependency already. This gets rid of an npm warning.Thanks a lot!