Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-lock.json to improve nsp vulnerability check #1510

Merged
merged 1 commit into from Oct 9, 2017
Merged

Add package-lock.json to improve nsp vulnerability check #1510

merged 1 commit into from Oct 9, 2017

Conversation

hekike
Copy link
Member

@hekike hekike commented Oct 9, 2017

Issues

Closes:

nsp finds vulnerabilities in the dependency tree without shrinkwrap if we have a package-lock.json file.

Changes

  • add package-lock.json file

retrohacker
retrohacker approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 😄

This should be safe to include again, nsp had pushed a release that broke dependency checking but it was fixed in 2.8.1

Thank you for doing this ❤️

@retrohacker retrohacker merged commit e6fe42e into restify:master Oct 9, 2017
@retrohacker retrohacker mentioned this pull request Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrohacker retrohacker retrohacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hekike @retrohacker