serveStatic is non-intuitive

[CodersBrothers]

KISS: Keep it simple stupid. Please make it this for static files plugins, all people have the same problem, in my ofice 5 persons give me the same as bug!!

if you assign this:

server.get(/\/docs\/public\/?.*/, restify.serveStatic({
  directory: './public'
}));

will mean that if you get the url "domain.com/docs/public" this will be load the content of "public" folder. END. Not at prefix for the entire route path... and your fairy tales... Kiss men, kiss...

[melkior]

+1

Had to rehack static.js for one application because of this, but would really like to see official solution. I'd suggest to make it as codersbrothers said, or even:

if(typeof opts.directory === 'function') {
file = opts.directory(req.path());
}

It's not even important what you do - if it's ok; but please do something

[gergelyke]

On it!

[CodersBrothers]

^^

[gergelyke]

#526

[gergelyke]

Which version are you using btw?

[CodersBrothers]

Im using 2.6.1, i use alwais the last, in package.json i put "*" :P

[CodersBrothers]

I saw that not its the last version, that 2.6.2 have:
#496 static plugin incorrectly handling directories; revert back to 2.6.0 version

This also add something KISS?

[gergelyke]

You should never use the asterisk, that is an antipattern!
npm install restify --save will save with correct versioning, please use this, not the asterisk

[CodersBrothers]

thanks, i will use right now!

[rprieto]

That's great news @gergelyke, I think the behaviour @CodersBrothers describes follows the principle of least surprise.

[gergelyke]

Just released the new version, please check it out!

[rprieto]

@gergelyke what is the new version you mentioned? I can't seem the find a fix-related commit recently.