prepareCheckCache function: Add MkdirAll() to restic-cache directory if it doesn't exist #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
requested changes
May 18, 2024
There was a problem hiding this comment.
Thanks for working on this issue! The code change itself is mostly fine, except for two minor issues.
However, the test case only seems to test existing behavior, but not the cache directory creating behavior added by this PR. Please fix that.
In addition, the PR must also be rebased, we don't want to merge merge commits. Ideally also squash the commits.
plant99
force-pushed
the
mkdirall-cachedir
branch
from
230217a
to
5287ce4
Compare
plant99
force-pushed
the
mkdirall-cachedir
branch
from
5287ce4
to
0271bb9
Compare
|
@MichaelEischer Please review the following two things again:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Earlier, if the specified cache dir didn't exist, restic continued
checkcommand with cache disabled.Henceforth, it tries to create the cache directory.
Was the change previously discussed in an issue or on the forum?
It was previously discussed here: #4437
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.