dump: Parallelize loading large files #4796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Improve dump performance for large files by loading their blobs concurrently using
repo.Connections()
goroutines.The largest part of the code changes in here is actually a modification of the bloblru cache. There's now a new
GetOrCompute
method that ensures that if multiple goroutines try to get the same blob that is not yet in the cache, that the blob will only be downloaded once.I've initially tried to use a sync.Pool to reuse byte slices, however, that turned out to be rather complicated to get right when using the bloblru cache. A byte slice may only be reused if no other goroutine can have a reference to it. With the current interface this is next to impossible to guarantee.
Was the change previously discussed in an issue or on the forum?
Basic variant as discussed in #3406 .
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/
that describes the changes for our users (see template).gofmt
on the code in all commits.