fix: close files #4770
Merged
fix: close files #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
requested changes
Apr 17, 2024
cmd/restic/cmd_repair_packs.go
Outdated
| @@ -72,6 +72,7 @@ func runRepairPacks(ctx context.Context, gopts GlobalOptions, term *termstatus.T | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer f.Close() | |||
There was a problem hiding this comment.
That change has no real effect as defer only runs once the surrounding function returns. And the operating system already closes all files once restic exists.
MichaelEischer
force-pushed
the
close_files
branch
from
5032c5b
to
001bb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
close files
Was the change previously discussed in an issue or on the forum?
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.