Refactor repair index / prune into the repository package #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies refactoring prune into the repository package.
The operation will always fail with an error if an index cannot be deleted. Thus, this change is purely cosmetic.
The current in-memory index becomes stale after prune or repair index have run. Thus, just drop the in-memory index altogether once these commands have finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Refactor repair index / prune loginc into the repository package.
The forget/prune/repair index commands now use the ui/printer interface for their progress output. Prune remains split into two functions
PlanPrunewhich create aPrunePlanwhich provides anExecute()method to perform the actual prune.The changes are accompanied with several testing cleanups and additional basic tests for the moved repair index / prune code.
In addition, repair index / prune now drop the then outdated in-memory index after the commands complete. This primarily serves to simplify testing and has no relevance for normal command executions.
Was the change previously discussed in an issue or on the forum?
Part of the refactoring for restic 0.17.0
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.