Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate s3legacy layout #4743

Merged

Conversation

MichaelEischer
Copy link
Member

@MichaelEischer MichaelEischer commented Mar 29, 2024

What does this PR change? What problem does it solve?

Disable support for the s3legacy layout to allow us to finally remove the code in a future restic version.

The local and sftp backend were also able to read repositories using the s3legacy layout. There is currently no documented migration path for such repositories, however, it is completely unclear whether such repositories even exist. I did not implement an upgrade path in restic, as the layout upgrade can also be handled using a short bash script if necessary.

Was the change previously discussed in an issue or on the forum?

Fixes #4602

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member Author

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelEischer MichaelEischer merged commit 55d56db into restic:master Apr 11, 2024
13 checks passed
@MichaelEischer MichaelEischer deleted the deprecate-s3legacy-layout branch April 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecation of Legacy S3 Layout and old Index Format
1 participant