backup: Ignore xattr.list permission error for parent directories #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
backup-xattr-parent-enoperm
branch
from
b714308
to
c52f350
Compare
MichaelEischer
force-pushed
the
backup-xattr-parent-enoperm
branch
2 times, most recently
from
df5a40c
to
f9f2a9d
Compare
MichaelEischer
force-pushed
the
backup-xattr-parent-enoperm
branch
from
f9f2a9d
to
9bdfef5
Compare
On FreeBSD, limited users may not be able to even list xattrs for the parent directories above the snapshot source paths. As this can cause the backup to fail, just ignore those errors.
MichaelEischer
force-pushed
the
backup-xattr-parent-enoperm
branch
from
9bdfef5
to
bf054c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
On FreeBSD, limited users may not be able to even list xattrs for the parent directories above the snapshot source paths. As this can cause the backup to fail, just ignore those errors. The "fix" is somewhat messy, but changing NodeFromFileInfo everywhere is probably not better either.
Was the change previously discussed in an issue or on the forum?
Fixes #3600
Fixes https://forum.restic.net/t/parent-directories-above-the-snapshot-source-path-fatal-error-permission-denied/7216
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.