New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: build for wasi #4105
base: master
Are you sure you want to change the base?
Conversation
What is the use case for running restic in the browser? There's no filesystem to read from? In addition, please remove the additional CI tasks and use our standard cross-building setup https://github.com/restic/restic/blob/master/.github/workflows/tests.yml#L200 . |
Expose internal functions to allow for http api and or SDK
This reverts commit 1b4d6e2.
Embedding restic into a website is fundamentally different from adding an HTTP API (well actually REST API) to restic. |
I see your point. I hadn't expected to draw any attention to this (draft) PR before it was ready, and I apologise for wasting resources by running workflows when it was not necessary. I suppose my goal can be restated as "enabling restic to be interacted with via a REST API", regardless of whether or not it is embedded in a website. For example, the functions in this file could allow one to create As I worked on this, I realised it doesn't need to be part of the main restic repo, as I can achieve my goal by exposing internal features of restic using I defer to your expertise as to whether or not there is any value in exposing restic's internals to the outside world. |
There are currently no plans on our side to expose the internals of restic as that would create an API that should remain mostly stable. Keeping the CLI backwards compatible is already enough work. |
What does this PR change? What problem does it solve?
Build for
wasi
Setting the stage for being able to run (a subset of)
restic
in the browserWas the change previously discussed in an issue or on the forum?
I can't see any discussion of Web Assembly on GitHub
Checklist
changelog/unreleased/
that describes the changes for our users (see template).gofmt
on the code in all commits.