Make restic find more intuitive by treating --newest as inclusive #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a datetime with a resolution lower than nanoseconds, find will list files modified up to the last nanosecond of the given datetime instead of the first.
hyperfekt
force-pushed
the
find_inclusive-newest
branch
from
a2f1c52
to
61bb890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When specifying
--newestfor restic find, the listed files will not actually include any with the stated modification time, but only those before it, which is not what the common assumption would be. With this PR, any files that have a modification timestamp that is an extension of the given option will be displayed also.Checklist
No. Unsure how to.
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.