Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'rewrite' command to exclude files from existing snapshots #3621

Closed
wants to merge 2 commits into from

Conversation

depau
Copy link

@depau depau commented Jan 6, 2022

What does this PR change? What problem does it solve?

Since the changes in #2731 haven't seen any progress in the last two years, I thought I'd pick up from where the original author left off and apply the suggested changes.

The current changes include:

  • Rebase on top of master + fix API usage
  • Apply the trivial review suggestions

This is still WIP.

From the original PR:

This adds 'rewrite' command that provides a way to remove data from existing snapshots.

This is some sort of preliminary pull requests. It's actually works here on test repo, but lacks tests, etc. Mostly to discuss things

Was the change previously discussed in an issue or on the forum?

closes #14
closes #2731

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
    • I'm planning to try stuff for the time being, I will rebase appropriately when ready
  • I'm done! This pull request is ready for review.

@DRON-666
Copy link
Contributor

DRON-666 commented Jan 6, 2022

@depau perhaps you'd be interested in this fork. I implemented all @aawsome suggestions and added some flags like --exclude-larger-than and --iexclude-file.
I think other flags like --set-path, --set-time, --set-host should be added as well.

@ibash
Copy link

ibash commented Jan 6, 2022

Thank you, using this right now!

return false, err
}

debug.Log("old snapshot %v forgotten", sn.ID())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: IMO it'd be better to make this Verbosef so that the user can see it.

@depau
Copy link
Author

depau commented Jan 7, 2022

@depau perhaps you'd be interested in this fork. I implemented all @aawsome suggestions and added some flags like --exclude-larger-than and --iexclude-file. I think other flags like --set-path, --set-time, --set-host should be added as well.

Sounds good! You should probably open your own pull request then, I'll close this one.

@danielsharvey
Copy link

@DRON-666 Will you create a PR for your changes?

@DRON-666
Copy link
Contributor

@danielsharvey I don't think another (third or fourth?) half-baked PR is a good idea.

@dionorgua
Copy link
Contributor

I don't have time right now to work on this. So if anybody want to take care of this pull request, feel free to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Files from Existing Snapshot
5 participants