Fix formatting of restic options
command
#3192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Printf
incmd_options.go
uses fixed (%-15s) formatting to simulate two-column table of extended options.This PR adds code to dynamically calculate the column width based on the longest option name.
Before:
After:
Also PR #3085 adds
bool
support tooptions
package, but without a corresponding test. This has been fixed too.And the last change fixes reuse of the
err
variable inTestOptionsApplyInvalid
, which can lead to panic instead of test failure.Was the change discussed in an issue or in the forum before?
No, but this PR based on first commit of #3067.
Checklist
- [x] I have added documentation for the changes (in the manual)- [x] There's a new file inchangelog/unreleased/
that describes the changes for our users (template here)gofmt
on the code in all commits