Add support for Google Cloud Storage (including Nearline). #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is impossible to review (the diff is too big for GitHub to display). Can you split this into two branches (and two PRs)? One that only has the dependencies and then another PR (against that first branch) that has your actual code contributions to restic? |
|
Can do. |
|
I must say that I find the large amount of code this backend depends on frightening... |
|
Any news on this ? I'd be glad to use restic with Google Storage too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for GCS per #211.
There are a few improvements that can be made on top of this, especially fixing GetReader so that it doesn't throw away extraneous bytes.