Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: Add --iexclude-file option #2898

Merged
merged 1 commit into from Aug 28, 2020

Conversation

aawsome
Copy link
Contributor

@aawsome aawsome commented Aug 25, 2020

What does this PR change? What problem does it solve?

closes #2427

Was the change discussed in an issue or in the forum before?

see #2427

Checklist

  • I have read the Contribution Guidelines
  • I have enabled maintainer edits for this PR
  • I have not added tests for all changes in this PR; did not find tests for --exclude-file nor --iexclude
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

@rawtaz rawtaz changed the title Add flag --iexclude-file to backup backup: Add --iexclude-file option Aug 25, 2020
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

I've made a few small changes: The help text of the backup command now prints file as flag-value name instead of stringArray. I've also updated the help text in the documentation along with rewording the changelog message a bit.

@MichaelEischer MichaelEischer merged commit 34a3adf into restic:master Aug 28, 2020
@aawsome aawsome deleted the add-iexclude-file branch August 31, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case insensitive exclude file
2 participants