Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use processed bytes for summary #2138

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Use processed bytes for summary #2138

merged 1 commit into from
Feb 10, 2019

Conversation

fd0
Copy link
Member

@fd0 fd0 commented Jan 6, 2019

What is the purpose of this change? What does it change?

When restic reads the backup from stdin, the number of bytes processed
was always displayed as zero. The reason is that the UI for the archive
uses the total bytes as returned by the scanner, which is zero for
stdin. So instead we keep track of the real number of bytes processed
and print that at the end.

Was the change discussed in an issue or in the forum before?

Closes #2136
Supersedes #2135

Checklist

When restic reads the backup from stdin, the number of bytes processed
was always displayed as zero. The reason is that the UI for the archive
uses the total bytes as returned by the scanner, which is zero for
stdin. So instead we keep track of the real number of bytes processed
and print that at the end.

Closes #2136
@fd0 fd0 requested a review from mholt January 6, 2019 12:19
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #2138 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   50.69%   50.68%   -0.02%     
==========================================
  Files         176      176              
  Lines       14167    14169       +2     
==========================================
- Hits         7182     7181       -1     
- Misses       5938     5941       +3     
  Partials     1047     1047
Impacted Files Coverage Δ
internal/ui/backup.go 0% <0%> (ø) ⬆️
internal/backend/rclone/backend.go 64.32% <0%> (-1.76%) ⬇️
internal/backend/b2/b2.go 79.54% <0%> (-1.14%) ⬇️
internal/archiver/blob_saver.go 97.53% <0%> (+4.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd8054...7c08401. Read the comment docs.

@fd0 fd0 mentioned this pull request Jan 6, 2019
7 tasks
@mholt
Copy link
Contributor

mholt commented Jan 7, 2019

I wonder if we could/should merge #1944 first and then include the JSON reporting in this change.

@fd0
Copy link
Member Author

fd0 commented Jan 7, 2019

Hm, I think you're right.

@fd0 fd0 merged commit 7c08401 into master Feb 10, 2019
@fd0 fd0 deleted the fix-2136 branch February 10, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants