Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive exclude file #2427

Closed
cfbao opened this issue Sep 28, 2019 · 3 comments · Fixed by #2898
Closed

Case insensitive exclude file #2427

cfbao opened this issue Sep 28, 2019 · 3 comments · Fixed by #2898
Labels
category: backup help: wanted state: need implementing cause/request established, need work/solution type: feature enhancement improving existing features

Comments

@cfbao
Copy link

cfbao commented Sep 28, 2019

Output of restic version

restic 0.9.5 compiled with go1.12.4 on windows/amd64

What should restic do differently? Which functionality do you think we should add?

Add case insensitive versions of the --exclude-file.

What are you trying to do?

Exclude files properly and easily on Windows.
Actually, not me personally, but I've seen some Windows users very confused about file path letter cases. For example:
https://forum.restic.net/t/exclude-file-to-block-folders-from-windows-drives/2070
Even at the end when the problem was resolved, I don't think they really understood the reason properly.
restic already has case insensitive include/exclude. I think it makes sense to extend it to --exclude-file.

Did restic help you or made you happy in any way?

Yes, every day.

@jim-collier
Copy link

This is kind a glaring missing option.

To be consistent with --exclude and --iexclude, and dodge a bullet of adding syntax to the exclude file (both from points of view of restic programmers and users), perhaps an option could be added: --iexclude-file.

And yes, restic makes me happy too.

@rawtaz
Copy link
Contributor

rawtaz commented Aug 25, 2020

I think there's a use case for this too, reading that forum thread it seems the author did what they were able to, but it was problematic even though they kind of understood it. So yeah, let's have someone file a PR for this, adding --iexclude-file! Maybe @aawsome or @greatroar?

@rawtaz rawtaz added category: backup help: wanted state: need implementing cause/request established, need work/solution type: feature enhancement improving existing features labels Aug 25, 2020
@aawsome
Copy link
Contributor

aawsome commented Aug 25, 2020

I just had a quick lock at it; it'll be only a few lines of code to add...
I can submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: backup help: wanted state: need implementing cause/request established, need work/solution type: feature enhancement improving existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@rawtaz @cfbao @jim-collier @aawsome and others