Skip to content

Commit

Permalink
Merge pull request #4745 from MichaelEischer/full-id-key-list
Browse files Browse the repository at this point in the history
key list: include full key id in JSON output
  • Loading branch information
MichaelEischer committed Apr 3, 2024
2 parents 49f98f2 + 5145c8f commit 9fb017e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
9 changes: 9 additions & 0 deletions changelog/unreleased/issue-4744
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Change: Include full key ID in JSON output of `key list`

We have changed the JSON output of the `key list` command to include the full
key ID instead of just a shortened version, as the latter can be ambiguous
in some rare cases. To derive the short ID, please truncate the full ID down to
eight characters.

https://github.com/restic/restic/issues/4744
https://github.com/restic/restic/pull/4745
6 changes: 4 additions & 2 deletions cmd/restic/cmd_key_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func listKeys(ctx context.Context, s *repository.Repository, gopts GlobalOptions
type keyInfo struct {
Current bool `json:"current"`
ID string `json:"id"`
ShortID string `json:"-"`
UserName string `json:"userName"`
HostName string `json:"hostName"`
Created string `json:"created"`
Expand All @@ -70,7 +71,8 @@ func listKeys(ctx context.Context, s *repository.Repository, gopts GlobalOptions

key := keyInfo{
Current: id == s.KeyID(),
ID: id.Str(),
ID: id.String(),
ShortID: id.Str(),
UserName: k.Username,
HostName: k.Hostname,
Created: k.Created.Local().Format(TimeFormat),
Expand All @@ -91,7 +93,7 @@ func listKeys(ctx context.Context, s *repository.Repository, gopts GlobalOptions
}

tab := table.New()
tab.AddColumn(" ID", "{{if .Current}}*{{else}} {{end}}{{ .ID }}")
tab.AddColumn(" ID", "{{if .Current}}*{{else}} {{end}}{{ .ShortID }}")
tab.AddColumn("User", "{{ .UserName }}")
tab.AddColumn("Host", "{{ .HostName }}")
tab.AddColumn("Created", "{{ .Created }}")
Expand Down

0 comments on commit 9fb017e

Please sign in to comment.