Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add configuration file #140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Add configuration file #140

wants to merge 3 commits into from

Conversation

wojas
Copy link
Contributor

@wojas wojas commented Jan 8, 2021

What is the purpose of this change? What does it change?

This implements a YAML config file mechanism for rest-server. See #139 for details.

Was the change discussed in an issue or in the forum before?

Closes #139 (config file)
Closes #94 (TLS hot reload)
Closes #74 (per-user config overrides)
TODO: Closes #73 (TLS client auth): still need to actually use the client TLS info

Try it out

To build this branch, you need git and a recent Go compiler installed and run the following:

git clone -b config-file https://github.com/wojas/rest-server.git
cd rest-server
go build -o rest-server ./cmd/rest-server

You will then have a rest-server binary in this directory.

Checklist

  • I have enabled maintainer edits for this PR
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

- Add config file support
- Use go-tlsconfig for TLS cert configuration
- Add NewServer func to create a Server from a config
- Remove Server attributes that only existed for flag parsing
Allow per-user overrides for AppendOnly and PrivateRepos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant