Converted the plugin to a caddy2 plugin #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Mar 13, 2024
|
Thanks for the thumbs up so far. Looking forward for the other maintainers to share their opinion. One hint, once this pull request is accepted you can also close #2. The append only option can now be configured in the json configuration file straight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request actually replaces the current caddy1 plugin by a newer version targeting caddy2.
Since the plugin model of caddy1 and caddy2 are incompatible this commit will actually introduce a "breaking change" for those which still rely on caddy1. However, caddy2 is out for quite some time now i think its safe to bump it here. The old versions are still tagged and can be accessed if needed.