Quick Fix #5
Open
Quick Fix #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get any of the
lib/include.foocommands to work - trying to install the repo I'd get a litany ofmake,pipenv, or other errors and couldn't install dependencies. I stripped all of this machinery out of theMakefilesomake installonly runsconda env update -f environment.yml, and can now install dependencies without issue.I also had to do some package updates -
pythonwas pinned at3.7, but that's incompatible with therestartsource code so I had to bump to 3.8. The packagexlrdwhich is used to display interactive grids has introduced some breaking changes in recent updates, so I swapped this out withopenpyxlwhich solved the issue.As of now, all the notebooks and
voilanotebooks run without problem on my machine; if we want we can put more effort into fixing all thelibstuff, but that also sounds like a lot of engineering effort to fix the pipenv bugs and add pre-commit hooks to a repository that probably won't see that much more development.