Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using library version macro #10

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lobis
Copy link
Member

@lobis lobis commented Jun 16, 2023

lobis Ok: 1

Please, REMOVE this text! This is just a template to serve as a reminder.

Please, give as much detail as possible at your PR and create the simplest possible PR to facilitate reviewing.

If your PR fixes a given issue, please specify the number followed by #

Fixes #

Give a detailed list of changes proposed in this pull-request. For example:

  • Feature added ...
  • Upgraded class TRestXYZ to ...
  • Added pipeline validation ...
  • Documented ...
  • Example added at ...
  • Script ...

Once your PR is approved remember to increase this library version version following these instructions. Remember to have a look to our general contribution guide.

Reminder: Please, new features and upgrades should be sufficiently documented and a corresponding validation test at the pipeline should be implemented.

Reminder: Adding this to your PR description will notify members at the library_dev team: @rest-for-physics/rawlib

Reminder: When writing your PR description remember to leave any necessary instructions to test the new implementation.

Reminder: to set-up the PR in the draft state when there is still work in progress, and make it ready once all pipelines have suceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant