Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example to generate decay spectra as a tree #103

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lobis
Copy link
Member

@lobis lobis commented Apr 13, 2023

lobis Large: 277

I have added a new example which illustrates how to use restG4 to generate the decay spectra of a given decay.

It stores an energy distribution as a separate TTree for gamma, e-, e+ and alpha particles produced by the decay. This tree is generated by a macro present in the example. A root histogram could also be produced which could be used as the primary energy distribution in a simulation.

The example could also be modified to compute the energy spectra after the decay products go through some material (e.g. 1cm of lead).

  • Create histograms with energy distribution for particles
  • Add README.md for example
  • Add basic validation to the example (check statistical properties of spectra)

@jgalan
Copy link
Member

jgalan commented Apr 13, 2023

Nice! On top of energy perhaps angular distribution could be registered, and use a TH2D histogram as an input for the generator later on.

@jgalan
Copy link
Member

jgalan commented Apr 13, 2023

Perhaps it would be good to have a REST_Geant4_RegisterParticleDistribution.C or something similar inside the macros directory, then the example validation could use this macro.

@lobis
Copy link
Member Author

lobis commented Apr 17, 2023

I just noticed the example 08 is failing for some reason, even tough this PR does not modify any code files... 🤔

@jgalan
Copy link
Member

jgalan commented Apr 19, 2023

I just noticed the example 08 is failing for some reason, even tough this PR does not modify any code files... 🤔

Perhaps a PR at geant4lib was merged and breaks this example. Those examples are not being validated at the geant4lib, that's why I suspect the source of the problem could be there.

@jgalan
Copy link
Member

jgalan commented Apr 19, 2023

It also seems that restG4 validation is not present inside the framework pipelines. So, any change in framework or geant4lib could break restG4 without noticing.

rest-for-physics/framework#394

@lobis
Copy link
Member Author

lobis commented Apr 27, 2023

Does anyone @jgalan @juanangp have any ideas why the pipeline is failing in the Example 08 (Alphas)? This PR only introduces a new example, it should not affect any other 🤔

(There is not a branch for Geant4lib).

@juanangp
Copy link
Member

Does anyone @jgalan @juanangp have any ideas why the pipeline is failing in the Example 08 (Alphas)? This PR only introduces a new example, it should not affect any other 🤔

Perhaps something has changed in framework? Just trigger master validation to check. I think we should trigger restG4 pipeline from framework or from any submodule PR. I tried time ago and didn't work out of the box since it requires several modifications in the workflow file.

@juanangp
Copy link
Member

Perhaps something has changed in framework? Just trigger master validation to check. I think we should trigger restG4 pipeline from framework or from any submodule PR. I tried time ago and didn't work out of the box since it requires several modifications in the workflow file.

Apparently something has changed in framework since master validation is failing https://github.com/rest-for-physics/restG4/actions/runs/4817404161

Last validation succeed happened on the 7th of March, so we should check what changed in between. My best guess is this PR rest-for-physics/framework#387

@jgalan
Copy link
Member

jgalan commented May 3, 2023

Perhaps something has changed in framework? Just trigger master validation to check. I think we should trigger restG4 pipeline from framework or from any submodule PR. I tried time ago and didn't work out of the box since it requires several modifications in the workflow file.

Apparently something has changed in framework since master validation is failing https://github.com/rest-for-physics/restG4/actions/runs/4817404161

Last validation succeed happened on the 7th of March, so we should check what changed in between. My best guess is this PR rest-for-physics/framework#387

It could be also something that changed on geant4lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants