Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some issues when reading units that contain expressions #464

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing some issues when reading units that contain expressions #464

wants to merge 4 commits into from

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Aug 9, 2023 •
edited by pull-request-badge bot

jgalan Ok: 10 Powered by Pull Request Badge

It fixes an issue evaluating units in strings than contain mathematical operators.

@jgalan jgalan added bug Something isn't working urgent and removed urgent labels Aug 9, 2023
@jgalan jgalan marked this pull request as ready for review August 28, 2023 07:37
@jgalan jgalan requested review from juanangp, nkx111, lobis and a team and removed request for juanangp August 28, 2023 07:37
@jgalan jgalan requested a review from a team August 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobis lobis lobis approved these changes

@nkx111 nkx111 Awaiting requested review from nkx111 nkx111 is a code owner

@juanangp juanangp Awaiting requested review from juanangp

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgalan @lobis